Convert to inline diagnostics in rustc_incremental#152044
Convert to inline diagnostics in rustc_incremental#152044rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rustc_incremental#152044Conversation
rustbot
added
S-waiting-on-review
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
| #[derive(Diagnostic)] | ||
| #[diag(incremental_corrupt_file)] | ||
| #[diag( | ||
| "corrupt incremental compilation artifact found at `{$path}`. This file will automatically be ignored and deleted. If you see this message repeatedly or can provoke it without manually manipulating the compiler's artifacts, please file an issue. The incremental compilation system relies on hardlinks and filesystem locks behaving correctly, and may not deal well with OS crashes, so whatever information you can provide about your filesystem or other state may be very relevant." |
There was a problem hiding this comment.
doesn't tidy reject such long lines?
There was a problem hiding this comment.
It doesn't seem like it does (it passes locally), probably because it is one big literal.
I can see if I can find a way to split it up, perhaps allowing multiple literal.
In the .ftl file this was also a single line tho, so this PR doesn't make the situation worse.
Would prefer to fix this in a separate PR since then I can do it for all rustc crates at the same time
There was a problem hiding this comment.
I've added this to the "unresolved questions" of the tracking issue to ensure it's not forgotten
|
I originally was wondering/hoping if we could use doc comments instead of an attribute. But that may be too magical |
Implementing this is not hard, tho slightly more annoying than the current implementation.
|
|
👌 r? me @bors r+ rollup |
rust-bors
bot
added
the
S-waiting-on-bors
rust-bors
bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
rustc_incremental_convert
branch
from
3d006f7 to
4cacfc0
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=lqd |
rust-bors
bot
added
S-waiting-on-bors
…convert, r=lqd Convert to inline diagnostics in `rustc_incremental` For rust-lang#151366
…uwer Rollup of 7 pull requests Successful merges: - #148967 (const-eval: always do mem-to-mem copies if there might be padding involved) - #152012 (Use `DEVELOPER_DIR` instead of a custom `xcode-select` script) - #152044 (Convert to inline diagnostics in `rustc_incremental`) - #152046 (Use glob imports for attribute parsers) - #152054 (Distinguish error message for `#[diagnostic::on_const]` on const trait impls) - #152059 (Fix some autodiff tests require Clto=fat) - #152073 (Convert to inline diagnostics in `rustc_mir_dataflow`)
5 participants
For #151366