Skip to content

Move impl Interner for TyCtxt to its own submodule #152148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zalathar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move impl Interner for TyCtxt to its own submodule #152148

Zalathar wants to merge 3 commits into from
+819 −801

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Feb 5, 2026 •
edited
Loading

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large rustc_middle::ty::context module.

There should be no change to compiler behaviour.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2026

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar
Copy link
Member Author

Zalathar commented Feb 5, 2026

I had been looking into whether it's feasible to extract TyCtxt and GlobalCtxt into their own module (since context.rs is so big and incoherent), when I stumbled upon this other chunk of extractable code.

@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

petrochenkov commented Feb 9, 2026

r=me after rebase.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2026
@Zalathar
Don't import TyCtxt from crate::ty::context
91d47a5
@Zalathar
Move impl Interner for TyCtxt to its own submodule
4234d2d
@Zalathar
Indicate that bidirectional_lang_item_map! declares functions
b7bfb76 
Requiring `fn` in the macro syntax makes it a little more obvious that the
macro declares functions with those names, and makes them easier to grep for.
@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar
Copy link
Member Author

Zalathar commented Feb 10, 2026

@bors r=petrochenkov

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 10, 2026

📌 Commit b7bfb76 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2026
@matthiaskrgr
Rollup merge of rust-lang#152148 - Zalathar:tcx-interner, r=petrochenkov
de88157 
Move `impl Interner for TyCtxt` to its own submodule

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module.

- The trait and its impl were introduced by rust-lang#97287.

---

There should be no change to compiler behaviour.
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 10, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152421 - matthiaskrgr:rollup-iLA2nqY, r=matthiaskrgr
62463eb 
Rollup of 7 pull requests

Successful merges:

 - #151152 (Add FCW for derive helper attributes that will conflict with built-in attributes)
 - #151954 (Add help message suggesting explicit reference cast for From/TryFrom)
 - #152148 (Move `impl Interner for TyCtxt` to its own submodule)
 - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds)
 - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns)
 - #152293 (Format heterogeneous try blocks)
 - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152148 - Zalathar:tcx-interner, r=petrochenkov
1efb99b 
Move `impl Interner for TyCtxt` to its own submodule

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module.

- The trait and its impl were introduced by rust-lang#97287.

---

There should be no change to compiler behaviour.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152148 - Zalathar:tcx-interner, r=petrochenkov
e8e2813 
Move `impl Interner for TyCtxt` to its own submodule

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module.

- The trait and its impl were introduced by rust-lang#97287.

---

There should be no change to compiler behaviour.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152148 - Zalathar:tcx-interner, r=petrochenkov
809b243 
Move `impl Interner for TyCtxt` to its own submodule

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module.

- The trait and its impl were introduced by rust-lang#97287.

---

There should be no change to compiler behaviour.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Feb 10, 2026
@bors
Auto merge of #152430 - JonathanBrouwer:rollup-mobk6KB, r=JonathanBro…
9889b37 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152364 (Port a lot of attributes to the new parser)
 - #151954 (Add help message suggesting explicit reference cast for From/TryFrom)
 - #152148 (Move `impl Interner for TyCtxt` to its own submodule)
 - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds)
 - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`)
 - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code)
 - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns)
 - #152293 (Format heterogeneous try blocks)
 - #152355 (Update documentation of rustc_macros)
 - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
 - #152425 (Port #![test_runner] to the attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 10, 2026
@JonathanBrouwer
Rollup merge of rust-lang#152148 - Zalathar:tcx-interner, r=petrochenkov
2aaf3a1 
Move `impl Interner for TyCtxt` to its own submodule

This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module.

- The trait and its impl were introduced by rust-lang#97287.

---

There should be no change to compiler behaviour.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zalathar @rustbot @rust-log-analyzer @petrochenkov