Port `rustc_reservation_impl` to the new attribute parser #152180

jdonszelmann · 2026-02-05T16:32:39Z

r? @JonathanBrouwer

rustbot · 2026-02-05T16:32:42Z

Some changes occurred in compiler/rustc_attr_parsing

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @JonathanBrouwer

compiler/rustc_hir/src/attrs/data_structures.rs

JonathanBrouwer · 2026-02-05T21:51:39Z

@rustbot author

rustbot · 2026-02-05T21:51:43Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jdonszelmann · 2026-02-07T13:34:06Z

should be better now @JonathanBrouwer @rustbot review

jdonszelmann · 2026-02-07T13:34:21Z

rangediff should be pretty clear

JonathanBrouwer · 2026-02-07T13:38:08Z

@bors r+ rollup
Yep awesome, ty :)

rust-bors · 2026-02-07T13:38:11Z

📌 Commit 86daea3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

JonathanBrouwer · 2026-02-07T13:40:05Z

@bors r-
Actually isn't that one rust-analyzer test gonna fail now?
r=me if ci green

JonathanBrouwer · 2026-02-07T15:33:10Z

@bors r+
I guess not

rust-bors · 2026-02-07T15:33:13Z

📌 Commit 86daea3 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

@JonathanBrouwer

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

@JonathanBrouwer

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

jdonszelmann · 2026-02-08T21:58:44Z

@bors r=jonathanbrouwer

rust-bors · 2026-02-08T21:58:47Z

📌 Commit f248ac0 has been approved by jonathanbrouwer

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - #150823 (Implement MVP for opaque generic const arguments) - #152071 (Implement stdio FD constants) - #152171 (Port `rustc_strict_coherence` to the new attribute parser) - #152291 (Port `rustc_insignificant_dtor`) Failed merges: - #152180 (Port `rustc_reservation_impl` to the new attribute parser)

rustbot · 2026-02-09T09:55:45Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-02-09T10:17:17Z

@bors r=jonathanbrouwer

rust-bors · 2026-02-09T10:17:21Z

📌 Commit 6babe68 has been approved by jonathanbrouwer

It is now in the queue for this repository.

Rollup of 3 pull requests Successful merges: - #152357 (std: Don't panic when removing a nonexistent UEFI var) - #152180 (Port `rustc_reservation_impl` to the new attribute parser) - #152276 (Add message format checking)

@JonathanBrouwer

Rollup merge of #152180 - jdonszelmann:port-rustc-reservation-impl, r=jonathanbrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 5, 2026

rustbot assigned JonathanBrouwer Feb 5, 2026

jdonszelmann mentioned this pull request Feb 5, 2026

Tracking issue: Attribute refactor #131229

Open

9 tasks

JonathanBrouwer reviewed Feb 5, 2026

View reviewed changes

compiler/rustc_hir/src/attrs/data_structures.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 5, 2026

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the port-rustc-reservation-impl branch from e4bfc54 to 86daea3 Compare February 7, 2026 13:33

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026

Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…

9853bec

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026

Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…

bcba606

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

JonathanBrouwer mentioned this pull request Feb 7, 2026

Rollup of 4 pull requests #152298

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026

Rollup merge of rust-lang#152180 - jdonszelmann:port-rustc-reservatio…

dbad4a0

…n-impl, r=JonathanBrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

JonathanBrouwer mentioned this pull request Feb 7, 2026

Rollup of 7 pull requests #152301

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2026

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the port-rustc-reservation-impl branch from 86daea3 to f248ac0 Compare February 8, 2026 21:31

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026

Zalathar mentioned this pull request Feb 9, 2026

Rollup of 4 pull requests #152373

Merged

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 9, 2026

This comment has been minimized.

Sign in to view

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2026

Port rustc_reservation_impl to the new attribute parser

6babe68

jdonszelmann force-pushed the port-rustc-reservation-impl branch from f248ac0 to 6babe68 Compare February 9, 2026 09:55

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2026

jhpratt mentioned this pull request Feb 9, 2026

Rollup of 3 pull requests #152382

Merged

rust-bors bot merged commit 98a3fa2 into rust-lang:main Feb 9, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 9, 2026

rust-timer added a commit that referenced this pull request Feb 9, 2026

Unrolled build for #152180

ac5fb86

Rollup merge of #152180 - jdonszelmann:port-rustc-reservation-impl, r=jonathanbrouwer Port `rustc_reservation_impl` to the new attribute parser r? @JonathanBrouwer

Uh oh!

Port rustc_reservation_impl to the new attribute parser #152180

Port rustc_reservation_impl to the new attribute parser #152180

Conversation

jdonszelmann commented Feb 5, 2026

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 5, 2026

Uh oh!

rustbot commented Feb 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

jdonszelmann commented Feb 7, 2026

Uh oh!

jdonszelmann commented Feb 7, 2026

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-bors bot commented Feb 7, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

jdonszelmann commented Feb 8, 2026

Uh oh!

rust-bors bot commented Feb 8, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 9, 2026

Uh oh!

jdonszelmann commented Feb 9, 2026

Uh oh!

rust-bors bot commented Feb 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Port `rustc_reservation_impl` to the new attribute parser #152180

Port `rustc_reservation_impl` to the new attribute parser #152180