Stop using rustc_layout_scalar_valid_range_* in rustc#152569
Stop using rustc_layout_scalar_valid_range_* in rustc#152569oli-obk wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in coverage instrumentation. cc @Zalathar |
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
b7ee60f to
01df8d6
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r=davidtwco |
|
oh wait @bors r- @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nd, r=<try> Stop using rustc_layout_scalar_valid_range_* in rustc
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (e8d615a): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.7%, secondary -3.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 485.967s -> 484.264s (-0.35%) |
|
@bors r=davidtwco The detailed view of the instruction count regression shows measures time improvements. Those look random, too, so I'm guessing it's just noise |
|
Given the large number of @bors rollup=iffy |
…range_end_end, r=davidtwco Stop using rustc_layout_scalar_valid_range_* in rustc Another step towards rust-lang#135996 Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.
|
I believe this is the cause of #152781 (comment), either alone or in combination (whether preliminary CI passes in #152782 will tell for sure) @bors r- |
|
Yeah this definitely has a soft conflict with the recently-merged #152703, because the macro mentions |
01df8d6 to
e62bc63
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=davidtwco |
…range_end_end, r=davidtwco Stop using rustc_layout_scalar_valid_range_* in rustc Another step towards rust-lang#135996 Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.
…range_end_end, r=davidtwco Stop using rustc_layout_scalar_valid_range_* in rustc Another step towards rust-lang#135996 Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.
…range_end_end, r=davidtwco Stop using rustc_layout_scalar_valid_range_* in rustc Another step towards rust-lang#135996 Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.
…uwer Rollup of 18 pull requests Successful merges: - #152799 (Subtree sync for rustc_codegen_cranelift) - #152569 (Stop using rustc_layout_scalar_valid_range_* in rustc) - #151059 (x86: support passing `u128`/`i128` to inline assembly) - #152097 (Suggest local variables for captured format args) - #152734 (Respect the `--ci` flag in more places in bootstrap) - #151703 (Fix ICE in transmutability error reporting when type aliases are normalized) - #152173 (Reflection TypeKind::FnPtr) - #152564 (Remove unnecessary closure.) - #152628 (tests: rustc_public: Check const allocation for all variables (1 of 11 was missing)) - #152658 (compiletest: normalize stderr before SVG rendering) - #152766 (std::r#try! - avoid link to nightly docs) - #152780 (Remove some clones in deriving) - #152787 (Add a mir-opt test for alignment check generation [zero changes outside tests]) - #152790 (Fix incorrect target in aarch64-unknown-linux-gnu docs) - #152792 (Fix an ICE while checking param env shadowing on an erroneous trait impl) - #152793 (Do no add -no-pie on Windows) - #152803 (Avoid delayed-bug ICE for malformed diagnostic attrs) - #152806 (interpret: fix comment typo)
|
@bors try jobs=dist-x86_64-linux-alt |
This comment has been minimized.
This comment has been minimized.
…nd, r=<try> Stop using rustc_layout_scalar_valid_range_* in rustc try-job: dist-x86_64-linux-alt
|
💔 Test for 0825e37 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors r- |
Another step towards #135996
Required some manual impls, but we already do many manual impls for the newtype_index types, so it's not really a new maintenance burden.