Make all multipart suggestions verbose

[estebank]

The ShowAlways style of suggestions is usually easier to understand than the inline style.

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in match checking

cc @Nadrieril

HIR ty lowering was modified

cc @fmease

[rustbot]

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 68 candidates
• Random selection from 17 candidates

[petrochenkov]

This is good, I never understood the logic behind choosing between multipart_suggestion_verbose and multipart_suggestion, perhaps there was none.

r=me after rebasing and making CI green.
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[estebank]

This is good, I never understood the logic behind choosing between multipart_suggestion_verbose and multipart_suggestion, perhaps there was none.

Honestly, inertia. The initial suggestion rendering was inline. Much later, I introduced the verbose mode for specific cases. Since then, the verbose mode became much better, to the point where it makes sense for it to be the default in most cases. There's a handful of cases where the inline suggestions make more sense (when it is a single word being changed, mainly). The multipart suggestion was introduced when inline was the better mode. This switch makes sense to me given how much easier to read the patch format is (specially because it makes incorrect suggestion spans more evident!).

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[estebank]

@bors r=petrochenkov

[rust-bors]

📌 Commit 37684bd has been approved by petrochenkov

It is now in the queue for this repository.