Skip to content

Move dep_node_debug#153268

Closed
nnethercote wants to merge 2 commits intorust-lang:mainfrom
nnethercote:mv-dep_node-debug
Closed

Move dep_node_debug#153268
nnethercote wants to merge 2 commits intorust-lang:mainfrom
nnethercote:mv-dep_node-debug

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Mar 2, 2026

Finding a better home for this code.

r? @Zalathar

@nnethercote
Remove EdgeFilter::index_to_node.
7a12baa 
It's unused.
@nnethercote
Move DepNodeFilter and EdgeFilter.
19cbf98 
They're currently in `rustc_middle::dep_graph::debug` but they're only
used in `rustc_incremental::assert_dep_graph`. This commit moves them to
that module.

This avoids some cross-crate dependencies (and `pub` visibilities), and
makes `rustc_middle` a little smaller, both of which are good.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2026

Zalathar is not on the review rotation at the moment.
They may take a while to respond.

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 2, 2026

The job x86_64-gnu-miri failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (94917532KB >= 52428800KB). Skipping cleanup.
##[group]Run echo "[CI_PR_NUMBER=$num]"
echo "[CI_PR_NUMBER=$num]"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Copy link
Member

Zalathar commented Mar 2, 2026

Looks like there are some build failures involving code gated behind #[cfg(debug_assertions)].

@nnethercote
Copy link
Contributor Author

nnethercote commented Mar 2, 2026

I overlooked some EdgeFilter uses in rustc_middle, so this change won't work.

@nnethercote nnethercote closed this Mar 2, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Zalathar Zalathar

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nnethercote @rustbot @rust-log-analyzer @Zalathar