Add Path::absolute method as alias for std::path::absolute#153272
Open
wmmc88 wants to merge 1 commit intorust-lang:mainfrom
Open
Add Path::absolute method as alias for std::path::absolute#153272wmmc88 wants to merge 1 commit intorust-lang:mainfrom
Path::absolute method as alias for std::path::absolute#153272wmmc88 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @tgross35 rustbot has assigned @tgross35. Use Why was this reviewer chosen?The reviewer was selected based on:
|
tgross35
requested changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Technically this should probably get an ACP, but given this is pretty straightforward and Chris is in favor it seems fine to just nominated here.
@rustbot label +I-libs-api-nominated
rustbot
added
I-libs-api-nominated
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
|
Also, please handwrite the PR description; the AI-generated restatement of diff contents is not helpful. (small typo in the commit message as well, says |
3 tasks
wmmc88
force-pushed
the
add-path-absolute-method
branch
3 times, most recently
from
be051c9 to
daee312
Compare
This comment has been minimized.
This comment has been minimized.
Member
|
This was discussed in the @rust-lang/libs-api meeting and we're happy to approve this. |
Amanieu
removed
the
I-libs-api-nominated
Add a convenience method Path::absolute() that delegates to the existing free function std::path::absolute(), mirroring the pattern of Path::canonicalize() delegating to fs::canonicalize(). Tracking issue: rust-lang#153328
wmmc88
force-pushed
the
add-path-absolute-method
branch
from
daee312 to
bde5b58
Compare
tgross35
approved these changes
Mar 3, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
…=tgross35 Add `Path::absolute` method as alias for `std::path::absolute` `Path::canonicalize()` is an alias for `fs::canonicalize()`, but there's no equivalent `Path::absolute()` for `path::absolute()`. This adds one. Discussed in rust-lang#92750 (comment), Chris [said](rust-lang#92750 (comment)) a PR would be welcome. Tracking issue: rust-lang#153328
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path::canonicalize()is an alias forfs::canonicalize(), but there's no equivalentPath::absolute()forpath::absolute(). This adds one.Discussed in #92750 (comment), Chris said a PR would be welcome.
Tracking issue: #153328