Continue refactoring MIR drop generation#64225
Closed
matthewjasper wants to merge 4 commits intorust-lang:masterfrom
Closed
Continue refactoring MIR drop generation#64225matthewjasper wants to merge 4 commits intorust-lang:masterfrom
matthewjasper wants to merge 4 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #63420) made this pull request unmergeable. Please resolve the merge conflicts. |
The logic for finding the correct unwind scopes is going to become more complicated, so we want to limit the amount of code that can directly access the fields of `Scope`.
Passing around a separate type is unnecessary and error-prone.
matthewjasper
force-pushed
the
more-drop-refactor
branch
from
af6826d to
899d10e
Compare
Collaborator
|
☔ The latest upstream changes (presumably #64584) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Ping from triage Thank you! |
Contributor
Author
|
I've moved some of the smaller changes back into #61430, and abandoned the rest, since they weren't necessary and were quite complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #61430
Typarameter fromschedule_drop.Scopesto its own module - the updated version of Makeintoschedule drop for the destination #61430 will make the logic significantly more complicated here.