Fix intra-doc links for associated constants on primitives #76093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
added
T-rustdoc
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
Previously, only associated functions would be resolved.
jyn514
force-pushed
the
prim-assoc-items
branch
from
4fe2b71 to
1404784
Compare
|
@bors r+ |
|
📌 Commit 1404784 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
jyn514
changed the title
lopopolo
added a commit
to artichoke/artichoke
that referenced
this pull request
Sep 2, 2020
- Primitive associated constants can now be resolved - rust-lang/rust#76093 - remove hard-coded links to `f64::NAN` in `spinoso-securerandom`. - Fix unresolved link to `artichoke_backend::eval::Eval`. The trait definition has lived in `artichoke-core` for some time now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only associated functions would be resolved. Fixes the issues in #75969 (comment).
I'm a little uncomfortable hard-coding the string constants, but it looks like that's how it's done elsewhere. I might make a follow-up PR at some point putting it in one place.
Not sure how to test associated types, since AFAIK there aren't any on primitives.
r? @Manishearth