Merged
Conversation
`[].split_inclusive()` currently yields a single, empty slice. That's different from `"".split_inslusive()`, which yields no output at all. I think that makes the slice version harder to use. The case where I ran into this bug was when writing code for generating a diff between two slices of bytes. I wanted to prefix removed lines with "-" and a added lines with "+". Due to `split_inclusive()`'s current behavior, that means that my code prints just a "-" or "+" for empty files. I suspect most existing callers have similar "bugs" (which would be fixed by this patch). Closes rust-lang#89716.
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
Previously some code paths would fail to evaluate the rvalue, while incorrectly indicating success with `Ok`. As a result the previous value of lhs could have been incorrectly const propagated.
…=m-ou-se Make split_inclusive() on an empty slice yield an empty output `[].split_inclusive()` currently yields a single, empty slice. That's different from `"".split_inslusive()`, which yields no output at all. I think that makes the slice version harder to use. The case where I ran into this bug was when writing code for generating a diff between two slices of bytes. I wanted to prefix removed lines with "-" and a added lines with "+". Due to `split_inclusive()`'s current behavior, that means that my code prints just a "-" or "+" for empty files. I suspect most existing callers have similar "bugs" (which would be fixed by this patch). Closes rust-lang#89716.
… r=jackh726 regression test for issue 87490 Closes rust-lang#87490
…i-obk Recover on invalid operators `<>` and `<=>` Thanks to rust-lang#89871 for showing me how to do this. Next, I think it'd be nice to recover on `<=>` too, like rust-lang#89871 intended, if this even works.
Fix typo for MutVisitor Fix typo for MutVisitor.
Return an error when `eval_rvalue_with_identities` fails Previously some code paths would fail to evaluate the rvalue, while incorrectly indicating success with `Ok`. As a result the previous value of lhs could have been incorrectly const propagated. Fixes rust-lang#91725. r? `@oli-obk`
…ister Avoid suggest adding `self` in visibility spec Fixes rust-lang#91783
Looser check for overflowing_binary_op Fix for issue rust-lang#91636 tight check resulted in ICE, this makes the check a little looser. It seems `eq` allows comparing of `supertype` and `subtype` if `lhs = supertype` and `rhs = subtype` but not vice versa, is this intended behavior ?
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit bae9270 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit bae9270 with merge 3464916c81a5775d48944f00bd9a9571cf4bc3bd... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
Member
Author
|
🙄 @bors retry spurious download failure |
bors
added
S-waiting-on-bors
Member
Author
|
@bors p=16 |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (d594910): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
<>and<=>#91597 (Recover on invalid operators<>and<=>)eval_rvalue_with_identitiesfails #91786 (Return an error wheneval_rvalue_with_identitiesfails)selfin visibility spec #91798 (Avoid suggest addingselfin visibility spec)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup