Simplify artifact comparison relevance #1281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #1277, this PR drastically simplifies how we think about relevance of an artifact comparison. If there are any relevant test result comparisons, then the artifact comparison as a whole is deemed relevant.
We should expect that more items will appear on the triage report.
@nnethercote - I like this change for the GitHub messages we post, but I'm less keen on this for the triage report. Perhaps for the triage report we can be a bit smarter. For example, if the primary summary has any comparisons OR the secondary summary has any medium or above test result comparison or 10 or more small ones. This would at least mean the triage filer doesn't need to filter out those that are just composed of small changes to secondary benchmarks. Thoughts?