Skip needless calls to get_align in some cases. #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CI faliures seme to be caused by me basing the PR on master. Should go away once the clippy fixes get merged. |
FractalFir
force-pushed
the
needless_align
branch
2 times, most recently
from
0c6cc23 to
e6281e0
Compare
Contributor
Author
|
Should be good for review now. |
antoyo
reviewed
Jun 24, 2025
Contributor
antoyo
left a comment
antoyo
left a comment
There was a problem hiding this comment.
A few questions and nitpicks.
Thanks for this nice improvement!
FractalFir
force-pushed
the
needless_align
branch
2 times, most recently
from
25e16c8 to
1140abd
Compare
FractalFir
force-pushed
the
needless_align
branch
from
1140abd to
8571aee
Compare
Contributor
Author
|
Should be good for review now! |
Contributor
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
create_typeandBuilder::loadfunctions to not callget_alignedwhen not necessary(for byte-sized types). It also contains some minor improvements to the comments inBuilder::loadfunction.