Skip to content

www: Fix copy icon position in Safari #3696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

noirgif
Copy link
Contributor

@noirgif noirgif commented Mar 7, 2024

This patch fixes the copy-icon position in Safari Version 17.3.1 (19617.2.4.11.12). It appears out of the box because "top: 50%" has no effect on Safari.

The 27px is from 50% of height(58px) - border-top-width(2px) - border-bottom-width(2px).

Before:
image

After:
image

It does not change the position of the icon on my Chrome 122.0.6261.94.

Fixes #3512.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This also looks good to me in Firefox (on macOS).

@djc djc requested a review from rami3l March 7, 2024 12:50
@rami3l rami3l added this pull request to the merge queue Mar 8, 2024
Merged via the queue into rust-lang:master with commit 45a2881 Mar 8, 2024
@noirgif noirgif deleted the fix-copy-icon-position branch March 8, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard copy icon misaligned on Safari
3 participants