Skip to content

test(cli/self-upd): use direct arg0 override for as_rustup_setup()#4929

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:test/as-rustup-setup-text-busy
Jun 30, 2026
Merged

test(cli/self-upd): use direct arg0 override for as_rustup_setup()#4929
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:test/as-rustup-setup-text-busy

Conversation

@rami3l

@rami3l rami3l commented Jun 30, 2026

Copy link
Copy Markdown
Member

This prevents a random error on Linux when running the test on CI. Sometimes, even after fs::copy() has returned, the executable is still considered "busy" by the OS, causing the test to fail with:

Os { code: 26, kind: ExecutableFileBusy, message: "Text file busy" }

This change avoids that by using a direct arg0 override instead.

@rami3l rami3l requested a review from djc June 30, 2026 07:13
@rami3l rami3l marked this pull request as ready for review June 30, 2026 07:13
This prevents a random error on Linux when running the test on CI.
Sometimes, even after `fs::copy()` has returned, the executable is still
considered "busy" by the OS, causing the test to fail with:

```rust
Os { code: 26, kind: ExecutableFileBusy, message: "Text file busy" }
```

This change avoids that by using a direct arg0 override instead.
@rami3l rami3l force-pushed the test/as-rustup-setup-text-busy branch from 68bf9b3 to c661b6c Compare June 30, 2026 07:38
@rami3l rami3l enabled auto-merge June 30, 2026 07:39
@rami3l rami3l added this pull request to the merge queue Jun 30, 2026
Merged via the queue into rust-lang:main with commit a663532 Jun 30, 2026
31 checks passed
@rami3l rami3l deleted the test/as-rustup-setup-text-busy branch June 30, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants