test(cli/self-upd): use direct arg0 override for as_rustup_setup()#4929
Merged
Conversation
djc
approved these changes
Jun 30, 2026
This prevents a random error on Linux when running the test on CI.
Sometimes, even after `fs::copy()` has returned, the executable is still
considered "busy" by the OS, causing the test to fail with:
```rust
Os { code: 26, kind: ExecutableFileBusy, message: "Text file busy" }
```
This change avoids that by using a direct arg0 override instead.
68bf9b3 to
c661b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a random error on Linux when running the test on CI. Sometimes, even after
fs::copy()has returned, the executable is still considered "busy" by the OS, causing the test to fail with:This change avoids that by using a direct arg0 override instead.