Revert "std_detect: RISC-V platform guide documentation" (#1779) #1792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @sayantn |
This was referenced Apr 30, 2025
This reverts commit e907456. This is due to a CI failure (technically broken HTML with duplicate IDs) caused by this commit (visibly fine but invalid per the HTML specification and detected by the LinkCheck tool on the Rust CI process). The author independently working on a rustdoc enhancement to enable writing multiple references to a single footnote. Once that change makes it to the stage0 compiler (the next beta), the original change will be acceptable again (postponed for possibly the version 1.89 cycle).
a4lg
force-pushed
the
riscv-arch-platform-guide-ch1
branch
from
96b1b10 to
b8be0cd
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1779.
This is due to a CI failure (technically broken HTML with duplicate IDs) caused by this commit (visibly fine but invalid per the HTML specification and detected by the LinkCheck tool on the Rust CI process).
The author independently working on a rustdoc enhancement to enable writing multiple references to a single footnote (rust-lang/rust#140434).
Once that change makes it to the stage0 compiler (the next beta), the original change will be acceptable again (postponed for possibly the version 1.89 cycle).
Related
Zcbextension #1789 (RISC-V platform guide v2; will be merged once multiple references to a single footnote is made acceptable)avx512dqandavx512vlimplication foravx512fp16rust#140389 (CI failure mainly caused by 1779)To pass the CI on the Rust side, 1779 should be reverted for now.
I authored this change to allow the technique used in 1779 and one of Rust's test cases.
Seemingly, it received good responses from reviewers and hope that this will make it to Rust beta 1.88 (requirement to make 1779 applicable again on Rust nightly 1.89).