Remove unused cloud compute entries and add hkBst #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi yes I'm indeed a team member |
Mark-Simulacrum
previously approved these changes
Feb 15, 2025
|
@oli-obk thanks for moving so decisively on this. I can't wait for this to go through. |
|
(CI needs to be fixed, |
hkBst
reviewed
Feb 19, 2025
oli-obk
force-pushed
the
oli-obk-patch-1
branch
from
b86d019 to
e6964f6
Compare
|
sorry for taking so long, should be all sorted now |
rylev
approved these changes
Feb 21, 2025
Comment on lines
+20
to
22
| alumni = [ | ||
| "Dajamante", | ||
| ] |
There was a problem hiding this comment.
Note: we don't always add alumni to marker teams since marker teams aren't really meant to indicate "service" to a particular effort, but I don't have strong feelings about this.
There was a problem hiding this comment.
The alternative here was deleting their user file, which, knowing nothing about this person's involvement, I did not want to suggest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eagerly adding @hkBst so once they need it they have access instead of needing to wait through another team PR cycle. This was discussed in the compiler team and had a few approvals and no disagreements. For context see rust-lang/rust#136931 (comment)
The others are either already team members (@WaffleLapkin), or are not contributing anymore