-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant try and perf access to gsoc-contributors #1656
base: master
Are you sure you want to change the base?
Conversation
Current policy is to not be granting people individual permissions, but rather grant permissions through teams. |
@jackh726 I wasn't aware of that policy. I wonder how reasonable it would be to grant |
That I'm in favor of. cc @Kobzol, not sure who else is a great ping here since I don't think it'll be a controversial decision |
I guess that we will turn the past I probably wouldn't tie this together with gsoc-contributors. But at the same time, I don't know of a different team for this :( We don't really have a good story for these situations at the moment. |
I am okay with saying that gsoc-contributors contains both current and past but still active (on the project) gsoc contributors - this way contributors have the same support to continue working on their project even past the end of the gsoc period. Of course, we could qualify this with some sort of criteria for moving to alumni (maybe we require that the mentor still is "+1" on the project). |
That's a good idea! Ok, let's do it that way. |
That said: not sure if the work @FractalFir has been doing on rust-lang/rust is related to the .NET/C backend at all, so not sure if it even makes sense in this situation to tie the two decisions |
It seems like a reasonable interim step. It will not surprise me even a little bit if FractalFir ends up on another team in the future. :) |
@joshtriplett if you edit the PR to put these perms on the team, I'll merge |
To chip in for a moment: The primary reason I looked at MIR optimization is that they benefit my project. For example, both .NET and some smaller C compilers have trouble optimizing Rust iterators. Additionally, I have hit some performance bootlenecks caused by the amount of generated C. For example, Since optimizations that reduce the amount of generated C also tend to reduce the amount of generated LLVM-IR, I am kind of killing two birds with one stone. Optimizations in |
Contributors may potentially work on performance, or on other things that benefit from try access. We trust gsoc-contributors to not abuse this access.
f3cdc23
to
b4ba0fe
Compare
Done. |
Contributors may potentially work on performance, or on other things
that benefit from try access. We trust gsoc-contributors to not abuse
this access.