Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant try and perf access to gsoc-contributors #1656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Feb 17, 2025

Contributors may potentially work on performance, or on other things
that benefit from try access. We trust gsoc-contributors to not abuse
this access.

@jackh726
Copy link
Member

Current policy is to not be granting people individual permissions, but rather grant permissions through teams.

@joshtriplett
Copy link
Member Author

@jackh726 I wasn't aware of that policy.

I wonder how reasonable it would be to grant try and perf to gsoc-contributors? We already grant dev-desktop to that team.

@jackh726
Copy link
Member

That I'm in favor of.

cc @Kobzol, not sure who else is a great ping here since I don't think it'll be a controversial decision

@Kobzol
Copy link
Contributor

Kobzol commented Feb 17, 2025

I guess that we will turn the past gsoc-contributors into alumni once GSoC 2025 starts (but maybe Fractal will do GSoC with us again, who knows 😆), so that wouldn't work, I think.

I probably wouldn't tie this together with gsoc-contributors. But at the same time, I don't know of a different team for this :( We don't really have a good story for these situations at the moment.

@jackh726
Copy link
Member

I am okay with saying that gsoc-contributors contains both current and past but still active (on the project) gsoc contributors - this way contributors have the same support to continue working on their project even past the end of the gsoc period. Of course, we could qualify this with some sort of criteria for moving to alumni (maybe we require that the mentor still is "+1" on the project).

@Kobzol
Copy link
Contributor

Kobzol commented Feb 17, 2025

That's a good idea! Ok, let's do it that way.

@jackh726
Copy link
Member

jackh726 commented Feb 17, 2025

That said: not sure if the work @FractalFir has been doing on rust-lang/rust is related to the .NET/C backend at all, so not sure if it even makes sense in this situation to tie the two decisions

@joshtriplett
Copy link
Member Author

It seems like a reasonable interim step. It will not surprise me even a little bit if FractalFir ends up on another team in the future. :)

@jackh726
Copy link
Member

@joshtriplett if you edit the PR to put these perms on the team, I'll merge

@FractalFir
Copy link

That said: not sure if the work @FractalFir has been doing on rust-lang/rust is related to the .NET/C backend at all, so if it even makes sense in this situation to tie the two decisions

To chip in for a moment: The primary reason I looked at MIR optimization is that they benefit my project. For example, both .NET and some smaller C compilers have trouble optimizing Rust iterators.

Additionally, I have hit some performance bootlenecks caused by the amount of generated C. For example, rustc transplies to ~2.1 GB of C. That causes most C compilers to slow down to a crawl.

Since optimizations that reduce the amount of generated C also tend to reduce the amount of generated LLVM-IR, I am kind of killing two birds with one stone. Optimizations in rustc also tend to have more eyes on them(compared to my project), which means it is much harder for a subtle bug to sneak in.

Contributors may potentially work on performance, or on other things
that benefit from try access. We trust gsoc-contributors to not abuse
this access.
@joshtriplett joshtriplett changed the title Grant try and perf access to @FractalFir Grant try and perf access to gsoc-contributors Feb 21, 2025
@joshtriplett
Copy link
Member Author

@joshtriplett if you edit the PR to put these perms on the team, I'll merge

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants