Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting review assignment limit #1790

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Apr 15, 2024

Part of #1753

With this patch we allow team members to set their own review capacity.

This will work by sending a message to the triagebot bot on Zulip. Usage:

  • work set #: will set the number of max PRs assigned to me

This setting will only work for a subset of Github users that volunteered (see here).

An update the documentation on the forge will follow up.

(I cannot test it, don't have yet a testing infrastructure with also a Zulip instance)

r? @jackh726

thank you

Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should limit this heavily until we know things are working smoothly. I think we can start by posting on zulip for 3-5 volunteers and hardcode them for now.

@apiraino apiraino force-pushed the allow-setting-review-assignment-limit branch 2 times, most recently from 4398ef5 to 1d5de2f Compare April 17, 2024 15:27
@xFrednet
Copy link
Member

Has there been any update on this PR? Is there anything I can help with?

@apiraino
Copy link
Contributor Author

Has there been any update on this PR? Is there anything I can help with?

thanks @xFrednet it's on my radar. Was a bit busy on other fronts but I plan to get back to this soon

@apiraino apiraino force-pushed the allow-setting-review-assignment-limit branch from 1d5de2f to 6d01f91 Compare June 12, 2024 13:18
@apiraino
Copy link
Contributor Author

Ok, update: before proceeding with this patch, there seems to be an inconsistency in the triagebot DB migration table that should be fixed first. I am waiting for this issue to be resolved by t-infra (thanks!)

@apiraino apiraino force-pushed the allow-setting-review-assignment-limit branch 3 times, most recently from adb23dd to 3490cef Compare September 11, 2024 14:44
@apiraino apiraino force-pushed the allow-setting-review-assignment-limit branch from 3490cef to e701af8 Compare November 6, 2024 10:41
@apiraino apiraino closed this Nov 6, 2024
@apiraino apiraino force-pushed the allow-setting-review-assignment-limit branch from e701af8 to 742b66b Compare November 6, 2024 10:56
@apiraino
Copy link
Contributor Author

apiraino commented Nov 6, 2024

For some reason I "broke" this PR. Work continues on #1854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants