ping goal owners #1828
Merged
ping goal owners #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 |
Some of the tests were failing.
jackh726
reviewed
Jul 27, 2024
| @@ -188,6 +189,12 @@ fn handle_command<'a>( | |||
| .await | |||
| .map_err(|e| format_err!("Failed to await at this time: {e:?}")) | |||
| } | |||
| Some("ping-goals") => { | |||
There was a problem hiding this comment.
So...I feel like it may be prudent to gate this so that only you (@nikomatsakis) can run this.
There was a problem hiding this comment.
...good idea, at least for now. :)
I'll make something better later.
nikomatsakis
force-pushed
the
ping-goal-owners
branch
from
7eef8d0
to
6fcccda
Compare
|
@jackh726 added the simplest of all possible ACLs :) |
jackh726
approved these changes
Jul 28, 2024
| /// Github ID of the user allowed to ping all group people. | ||
| /// | ||
| /// FIXME: We should create a team for the person/people managing the goals program | ||
| /// and check that the zulip person is on it, but I'm too |
There was a problem hiding this comment.
Left out a word here, but its funnier this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a zulip command to ping goal owners. I intend this to run once a week eventually but right now it's still executed manually.