notify_zulip: handle labels set when opening the pr #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
May 7, 2025
apiraino
reviewed
May 7, 2025
| IssuesAction::Closed | IssuesAction::Reopened => { | ||
| Ok(Some(parse_close_reopen_input(event, config))) | ||
| IssuesAction::Opened | IssuesAction::Closed | IssuesAction::Reopened => { | ||
| Ok(Some(parse_open_close_reopen_input(event, config))) |
There was a problem hiding this comment.
I was looking for a slightly more parseable (ha!) name for this function. parse_input()? get_notification_input()? Suggestions?
There was a problem hiding this comment.
We already have a parse_label_change_input for label and unlabel events, I rather not make less distinctive.
Better have a descriptive function name than a short one that is confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle labels set when opening the PR as if they were added in
notify_zuliphandler.We re-use
messages_on_add, since it's the conceptually same thing as if they were manually added just after the PR was opened.cc @apiraino @fmease
Fixes #1973