Skip to content

pool: add relay Monitor #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

pool: add relay Monitor #851

merged 1 commit into from
May 6, 2025

Conversation

yukibtc
Copy link
Member

@yukibtc yukibtc commented Apr 28, 2025

Introduce the Monitor struct to track relay status changes via channel notifications.

Closes #850

@yukibtc yukibtc added this to the Release v0.42 milestone Apr 28, 2025
yukibtc added a commit that referenced this pull request Apr 28, 2025
…annel

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from 818f5ce to 04883a0 Compare April 28, 2025 08:00
yukibtc added a commit that referenced this pull request Apr 28, 2025
…annel

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from 04883a0 to 4d9474c Compare April 28, 2025 08:11
@yukibtc yukibtc changed the title Relay status notification channel pool: add relay Monitor Apr 28, 2025
yukibtc added a commit that referenced this pull request Apr 28, 2025
Introduce the `Monitor` struct to track relay status changes via channel notifications.

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from 4d9474c to a54e14e Compare April 28, 2025 09:23
@yukibtc yukibtc marked this pull request as ready for review April 28, 2025 09:23
@yukibtc
Copy link
Member Author

yukibtc commented Apr 28, 2025

@Ma233, what do your think?

I've added an example at crates/nostr-sdk/examples/monitor.rs.

If needed, the MonitorNotification can be extended in the future.

yukibtc added a commit that referenced this pull request Apr 28, 2025
Introduce the `Monitor` struct to track relay status changes via channel notifications.

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from a54e14e to c78b9e7 Compare April 28, 2025 09:27
yukibtc added a commit that referenced this pull request Apr 28, 2025
Introduce the `Monitor` struct to track relay status changes via channel notifications.

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from c78b9e7 to 996552a Compare April 28, 2025 10:17
yukibtc added a commit that referenced this pull request Apr 28, 2025
Introduce the `Monitor` struct to track relay status changes via channel notifications.

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from 996552a to 448b3a5 Compare April 28, 2025 14:07
@Ma233
Copy link
Contributor

Ma233 commented May 6, 2025

Hi @yukibtc, I apologize for the delayed response. This PR looks great to me.

Introduce the `Monitor` struct to track relay status changes via channel notifications.

Closes #850

Pull-Request: #851
Signed-off-by: Yuki Kishimoto <[email protected]>
@yukibtc yukibtc force-pushed the relay-status-changes-channel branch from 448b3a5 to 8efe87d Compare May 6, 2025 06:07
@yukibtc yukibtc merged commit 8efe87d into master May 6, 2025
5 checks passed
@yukibtc yukibtc deleted the relay-status-changes-channel branch May 6, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please allow Relay to be public available
2 participants