Conversation
Adds the raw `EdidDiscoveredProtocol` struct and GUID for `EFI_EDID_DISCOVERED_PROTOCOL` (UEFI Spec 2.10, section 12.9), which exposes the raw EDID discovered for the display device backing a `GraphicsOutput` handle.
Adds a safe wrapper around `EdidDiscoveredProtocol` in `uefi::proto::console::gop`, alongside `GraphicsOutput`.
Adds an integration test for `EdidDiscovered`. Also renames `gop::test` to `gop::gop_test` to disambiguate it from the new `gop::test_edid_discovered`.
Contributor
Author
|
The display drivers that are bundled in the ovmf-prebuilt image that we use for our qemu tests do not install EFI_EDID_DISCOVERED_PROTOCOL on any backend (for e.g. the QemuVideoDxe has a TODO for this). Due to this, the test skips early. I couldnt think of a way where in we still use our ovmf-prebuilt and still get to add the protocol to test it. Any thoughts @phip1611 
|
Member
|
I can run it tomorrow on real hardware and test it; i was planning to do a UEFI test on real hardware anyway :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EdidDiscoveredProtocolbindings inuefi-raw.EdidDiscoveredinuefi.EdidDiscoveredprotocol.reference:
Closes #2072
Checklist