Stack overflow during decompression with malicious input in zlib-rs #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the report! Could you make it more clear that this is purely a denial-of-service issue? It would be nice to put "Denial of service" in the title and/or in the first sentence of the description. "Stack overflow" is superficially similar to "stack buffer overflow" which may lead people not well versed in the distinction to conclude that this issue is more severe than it actually is. Also please drop the comments from the TOML part of the file. |
|
I've updated the description and title to hopefully make that point a little more clear. And the comments should now all have been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.