Update diesel and diesel-async to newest versions - #3005
Open
mcclure wants to merge 3 commits into
Open
Conversation
…d 0.9.2. This requires bumping deadpool (because of diesel-async 0.8) and changing the signature on a function call (because of diesel-async 0.9).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates diesel and diesel-async to the newest versions. This requires minor changes:
FnOnce<Box<Pin<Future>>>toFuture. For an explanation of this, see the diesel-async 0.9 release notes or this Mastodon discussion. If you don't like this ,yo ucan avoid it by fixing disel-async at 0.8.This patch rests atop my existing PR #2970 . I hope that's OK. It is probably possible to rebase 2c18c without #2970 (but I'd rather you accepted #2970, as it's minor and benign).
I tested this patch successfully with
test.sh --core,test.sh --examples, and my own third-party app which makes sense of async diesel in the db pool.