Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default objects with Object.assign -> Spread Operator #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set default objects with Object.assign -> Spread Operator #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,9 @@ function showEmployeeList(employees) {

**[⬆ back to top](#table-of-contents)**

### Set default objects with Object.assign
### Set default objects with Spread Operator

When using the same name for your properties in an Object, the second property will overwrite the first.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is re-stated in the comment at the bottom where it says config now equals. I prefer to keep the explanation there as opposed to a note here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection to relocate the explanation, but I don't recommend removing it.


**Bad:**

Expand Down Expand Up @@ -543,18 +545,14 @@ const menuConfig = {
};

function createMenu(config) {
let finalConfig = Object.assign(
{
title: "Foo",
body: "Bar",
buttonText: "Baz",
cancellable: true
},
config
);
return finalConfig
const defaultConfig = {
title: "Foo",
body: "Bar",
buttonText: "Baz",
cancellable: true,
};
return { ...defaultConfig, ...config };
// config now equals: {title: "Order", body: "Bar", buttonText: "Send", cancellable: true}
// ...
}

createMenu(menuConfig);
Expand Down