Add Xiaomi Smart Pet Fountain 2 support#2069
Open
JanOstrowka wants to merge 5 commits intorytilahti:masterfrom
Open
Add Xiaomi Smart Pet Fountain 2 support#2069JanOstrowka wants to merge 5 commits intorytilahti:masterfrom
JanOstrowka wants to merge 5 commits intorytilahti:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2069 +/- ##
==========================================
+ Coverage 82.26% 82.48% +0.21%
==========================================
Files 197 201 +4
Lines 19145 19381 +236
Branches 1052 1060 +8
==========================================
+ Hits 15750 15986 +236
Misses 3218 3218
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I split the Read the Docs cleanup into a dedicated follow-up PR: #2070. That PR fixes the warning sources causing the RTD build to fail on Python 3.9 / Sphinx 7.4.7, and I verified it locally with:
So the remaining RTD failure on this feature PR should be addressable independently of the pet fountain implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python-miiosupport for Xiaomi Smart Pet Fountain 2 (xiaomi.pet_waterer.70m2)Why
Home Assistant core review requested that the pet fountain implementation live in the library used by the integration instead of being carried as a local helper in
xiaomi_miio.Included
XiaomiPetFountaindevice classmiio.__init__Related
Validation
python3 -m py_compileon the new pet fountain package and testsI was not able to run the full
pytestsuite in this environment becausepytestis not installed locally.