Skip to content

fix: clippy useless_borrows_in_formatting warnings - #129

Merged
shikhar merged 1 commit into
mainfrom
devin/1785352434-fix-clippy
Jul 29, 2026
Merged

fix: clippy useless_borrows_in_formatting warnings#129
shikhar merged 1 commit into
mainfrom
devin/1785352434-fix-clippy

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

cargo clippy --workspace --all-features --all-targets -- -D warnings --allow deprecated (the CI invocation) reported 15 clippy::useless_borrows_in_formatting warnings, all in tests/server_integration_test.rs — a redundant & on ctx.bucket_name inside format! args:

-    ctx.server_url, &ctx.bucket_name, object_key
+    ctx.server_url, ctx.bucket_name, object_key

Test-only change, no behavior difference. Clippy, cargo fmt --check, and cargo test (124 tests) all pass.

Link to Devin session: https://app.devin.ai/sessions/2025dc3186574c619611f6bf6d1e29d1
Requested by: @shikhar

Co-Authored-By: Shikhar Bhushan <shikhar@s2.dev>
@shikhar shikhar self-assigned this Jul 29, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

Removes 15 redundant borrows of ctx.bucket_name in integration-test formatting arguments to satisfy Clippy without changing generated request URLs.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

Passing a String directly to these formatting macros is equivalent to passing a reference, and the values remain available for subsequent use.

Important Files Changed

Filename Overview
tests/server_integration_test.rs The formatting-only borrow removals preserve ownership and runtime behavior while resolving the reported Clippy warnings.

Reviews (1): Last reviewed commit: "fix clippy warnings in integration tests" | Re-trigger Greptile

@shikhar
shikhar merged commit 22e4c5e into main Jul 29, 2026
7 checks passed
@shikhar
shikhar deleted the devin/1785352434-fix-clippy branch July 29, 2026 19:26
@github-actions github-actions Bot mentioned this pull request Jul 29, 2026
shikhar pushed a commit that referenced this pull request Jul 29, 2026
## 🤖 New release

* `cachey`: 0.10.13 -> 0.10.14

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.10.14](0.10.13...0.10.14)
- 2026-07-29

### Fixed

- clippy useless_borrows_in_formatting warnings
([#129](#129))

### Other

- use Minimus Rust builder
([#128](#128))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant