Skip to content

Conversation

@Steepspace
Copy link
Contributor

  • Add feature to flag each tower in the EMCal interface board as having badChi2 if the majority of the towers in the interface board have a badChi2.
  • Default threshold is set to 0.5 (half of the interface board), but can be adjusted as desired.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work for users)
  • Requiring change in macros repository (Please provide links to the macros pull request in the last section)
  • I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

- Add feature to flag each tower in the EMCal interface board as having badChi2 if the majority of the towers in the interface board have a badChi2.
- Default threshold is set to 0.5 (half of the interface board), but can be adjusted as desired.
- Compute the ratio of the towers with badChi2 in an IB with respect to the avalible towers in the IB.
- This way if 70% of an IB is flagged as dead, then the ratio of badChi2 towers is made relative to the 30% of the IB that is alive for the threshold check.
- Ensure that no division by 0 occurs, and skip the IB if no towers are ok.
@bseidlit
Copy link
Contributor

bseidlit commented Aug 6, 2025

Is there a particular problem this is trying to solve? It would seem easier to modify the maps before adding them to the CDB.

@Steepspace
Copy link
Contributor Author

Is there a particular problem this is trying to solve? It would seem easier to modify the maps before adding them to the CDB.

Hi Blair, yes, @vbailey2 requested this feature. The issue is occurring on the level of individual events, where the majority of the interface board is marked as isBadChi2, however, a few towers slip through, and these are occasionally reconstructed into high pT jets. We can't address this issue by modifying the cdb maps because they represent an aggregate behavior over the entire run. The idea is to check if the majority of the towers in an interface board are marked as having isBadChi2 for an event, then set all towers in the interface board as having isBadChi2 so they would fail the isGood check and not produce these fake high pT jets.

image

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit bc526c3b3645b8d01151383937756edb0824b94a:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit 97648bbcac23f117ca7c2a4c315131805d0c3158:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@sphenix-jenkins-ci
Copy link

Build & test report

Report for commit 6d5b0ef06b8547f64d64d8fa9dd56268f206acf4:
Jenkins passed


Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@pinkenburg pinkenburg marked this pull request as ready for review August 8, 2025 17:14
@pinkenburg pinkenburg marked this pull request as draft August 8, 2025 17:39
@Steepspace
Copy link
Contributor Author

After discussion at the Mini Calo meeting today, it was decided to hold off on merging this feature as:

  • Adds more complexity to the existing function, resulting in more code maintenance.
  • There are potentially other approaches that can be investigated such as an offline tower minimum energy threshold, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants