Fixed calo v2 #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

danjlis wants to merge 4 commits into sPHENIX-Collaboration:master from danjlis:fixed_calo_v2

Contributor

danjlis commented Dec 18, 2025

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

Adds option for determine tower background to use average call which now has a default in the CDB, but can be loaded as a CDBTTree. Code to generate this is to be added to the calibrations repository.

TODOs (if applicable)

Links to other PRs in macros and calibration repositories (if applicable)

Daniel J Lis and others added 3 commits

December 17, 2025 20:59


          djl -- add average calo v2 as an option for flow

5adbf5c


          add return if LoadCalibrations failed

35a6b31


          djl -- array to vector

2e9ccc7

sphenix-jenkins-ci bot commented Dec 18, 2025

Build & test report

Report for commit 35a6b31e4b87d1ce0fe8e10fb3450750dae4538a:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

sphenix-jenkins-ci bot commented Dec 18, 2025

Build & test report

Report for commit 2e9ccc7bd05638acfab1959cc62d9e2bbca8515d:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = -0 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = -0 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is UNSTABLE, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

pinkenburg reviewed

View reviewed changes

offline/packages/jetbackground/DetermineTowerBackground.cc Outdated

    
                    cdbtree_calo_v2 = new CDBTTree(calibdir);

                  }

                if (!cdbtree_calo_v2)

Contributor

pinkenburg Dec 18, 2025

the ctor of cdbttree will always return an object, checking for null will never trigger. Errors are caught in the LoadCalibrations method and the code will do a hard exit() if an error is encountered:

coresoftware/offline/database/cdbobjects/CDBTTree.cc

Line 490 in 9975969

void CDBTTree::LoadCalibrations()


          djl -- change error handling to exit and not check for nullptr

ce0d3af

sphenix-jenkins-ci bot commented Dec 19, 2025

Build & test report

Report for commit ce0d3af05d26ad9aaf3275d50dce0afd8d54b2ec:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 27.45 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 41.6183 / 72, and combined p-Value = 0.998442
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 0.4559 / 42, and combined p-Value = 1
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 14.2531 / 42, and combined p-Value = 0.999981
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA from run2pp 53877: build is SUCCESS, 📊 trends
  - 📊 QA-intt : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-micromegas : combined Chi2/nDoF = -0 / 6, and combined p-Value = 1
  - 📊 QA-mvtx : combined Chi2/nDoF = -0 / 18, and combined p-Value = 1
  - 📊 QA-siliconseeds : combined Chi2/nDoF = 0.0450636 / 20, and combined p-Value = 1
  - 📊 QA-tpc : combined Chi2/nDoF = -0 / 48, and combined p-Value = 1
  - 📊 QA-tpcseeds : combined Chi2/nDoF = 0.000878591 / 28, and combined p-Value = 1
  - 📊 QA-trackfit : combined Chi2/nDoF = 5.83914 / 32, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet