Skip to content

Conversation

@largewedge
Copy link

@largewedge largewedge commented Aug 15, 2025

See sPHENIX-Collaboration/coresoftware#3828 . It also may make more sense to use sEPDGeomMapping in Fun4All_CaloProduction.C to match other calos.

@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 3099856a398add8e0b43df029a7910dcf26e94a8. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

@bseidlit
Copy link
Contributor

  1. I think we want to put the geometry on the CDB. In principle this is fine for now.
  2. I think you should add the CaloTowerStatus stuff. Your doing the template fit now? if so the setting of isBadChi2 flag would be super useful to remove ADC readout issue causing crazy energies. The CaloTowerStatus has a few more things it can set but it will just ignore them if you don't have relevant CDB files.

@largewedge
Copy link
Author

@bseidlit The template fit isn't currently in use but should be ASAP, so it would make sense to add CaloTowerStatus. Putting the geometry on the CDB would be logical and would presumably be part of moving the geometry node handling for the sEPD into CaloGeomMapping

@pinkenburg pinkenburg marked this pull request as draft August 15, 2025 19:32
@sphenix-jenkins-ci
Copy link

For repository maintainers, please start the CI check manually (feedback)

This is an automatic message to assist manually starting CI check for this pull request, commit 9e0f6e8f0b5e843a417474048df7e4116245f4b1. macros pull request require a manual start for CI checks, in particular selecting which coresoftware and calibrations versions to check against this macros pull request.

sPHENIX software maintainers: please make your input here and start the Build:

build

Note:

  1. if needed, fill in the pull request ID for the coresoftware pull request, e.g. origin/pr/1697/merge for PR#1697 in sha_coresoftware. Default is to check with the master branch.
  2. click Build button at the end of the long web page to start the test

Automatically generated by sPHENIX Jenkins continuous integration
sPHENIX             jenkins.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants