-
Notifications
You must be signed in to change notification settings - Fork 14
refactor: use deployments package #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PaulRBerg
wants to merge
8
commits into
main
Choose a base branch
from
refactor/deployments-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2f4839
to
fe0ebaf
Compare
fe0ebaf
to
2e5f6d1
Compare
ecbdb5c
to
d55bdac
Compare
d55bdac
to
0da211c
Compare
0da211c
to
ec05925
Compare
ec05925
to
104f14d
Compare
The PR is now ready for your review @sablier-labs/evm |
eda32e5
to
0e7fc98
Compare
refactor: rename components refactor: turn MDX components into JSX
0e7fc98
to
5cbe647
Compare
5cbe647
to
1e8cc1b
Compare
1e8cc1b
to
84a826a
Compare
Click to view recordingScreen.Recording.2025-04-30.at.11.26.41.mov |
smol-ninja
requested changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phenomenal work @PaulRBerg.
feat: LinkPreviewIndexers feat: LinkPreviewTheGraph refactor: move autogen scripts to a new directory
Thanks for your kind feedback @smol-ninja @andreivladbrg waiting for your review (no rush, just FYI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left to do:
Load Legacy data from the deployments packageedit: it's actually alright to hard-code the Legacy contract addresses. We will never ship any new updates.