Skip to content

Reject oversized request bodies before reading#610

Open
safal207 wants to merge 1 commit into
mainfrom
fix-oversized-request-rejection-5255638131345680818
Open

Reject oversized request bodies before reading#610
safal207 wants to merge 1 commit into
mainfrom
fix-oversized-request-rejection-5255638131345680818

Conversation

@safal207

Copy link
Copy Markdown
Owner

The Reflection Dashboard API now correctly identifies and rejects requests where the Content-Length exceeds the 1MB limit before attempting to read the body. It returns a semantically correct 413 Payload Too Large status code. This was achieved by introducing a ContentTooLargeError exception and updating the do_POST error handling logic. Unit tests have been added to ensure this behavior is maintained.


PR created automatically by Jules for task 5255638131345680818 started by @safal207

Reject incoming requests with Content-Length larger than the 1MB cap
before reading the body (BUG-API-01).

- Defined `ContentTooLargeError` exception.
- Updated `_read_json_body` to raise `ContentTooLargeError` for oversized requests.
- Updated `do_POST` to catch `ContentTooLargeError` and return `413 Payload Too Large`.
- Added unit tests in `tests/test_reflection_dashboard_api_oversized.py`.

Co-authored-by: safal207 <55020240+safal207@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant