Skip to content

explorer: merge search and terminal #8299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Apr 23, 2025

So, this isn't perfect, there is really a lot going on, but I think this hits the general idea. All the features I'm aware of are still the same.

What I changed is

  • where the "terminal mode" banner appears (further up)
  • checking for the return key for submitting the mini terminal command in the keydown handler (and not a <form ...> tag wrapped around the input box
  • The icons for showing other users' presence is further to the right, because in the middle it feels awkward (chat is everywhere to the right)
  • The intended flex layout is 2:1, but it's not really visible in the screencast. It also wraps as before, if really narrow.

additionally: this fixes a few typos and Antd deprecations

screen-capture.2.webm

@haraldschilly haraldschilly force-pushed the explorer-merge-search-terminal branch from 7ede903 to ac186cc Compare April 23, 2025 16:35
@haraldschilly haraldschilly marked this pull request as ready for review April 23, 2025 16:39
@williamstein
Copy link
Contributor

wow, that looks awesome!!

@williamstein williamstein merged commit 938325f into master Apr 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants