perf: Allow toggling events off statically - #1287
Open
ChayimFriedman2 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
Contributor
Author
|
Seems insignificant. But maybe still worth it given how easy this is? Not sure. |
They are typically only used for tests, and removing them statically removes a load+branch and sometimes more (the callback can pessimize compiler optimizations).
ChayimFriedman2
force-pushed
the
no-event
branch
from
August 12, 2026 17:47
bc1c145 to
cd235b9
Compare
Contributor
|
I suspect that it's not significant, but the best way to tell is to run some benchmarks on ty/rust-analyzer to see if there's a meaningful difference. If not, I'm inclined to keep as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are typically only used for tests, and removing them statically removes a load+branch and sometimes more (the callback can pessimize compiler optimizations).
This will fail tests as they need this. I'll fix this, but this will prevent seeing the benchmark impact, so I'm first opening the PR without.