Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old Salsa, rename salsa-2022 crate to salsa #501

Merged
merged 8 commits into from
Jun 19, 2024

Conversation

mbrobbel
Copy link
Contributor

Closes #493.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for salsa-rs ready!

Name Link
🔨 Latest commit d65914b
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/667168cbbb98a40008d47304
😎 Deploy Preview https://deploy-preview-501--salsa-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbrobbel mbrobbel marked this pull request as ready for review June 18, 2024 11:00
@nikomatsakis
Copy link
Member

Woohoo!

cp _redirects versions
mdbook build
mkdir versions
mv book/html/* versions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only caveat here: I feel like maybe we should keep the older book for now. But I am happy to not have the complexity, maybe we can just "clone" the old book into the new book as a subdirectory for the time being or something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Doesn't have to be done in this PR)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #503

>
> This page describes the unreleased "Salsa 2022" version, which is a major departure from older versions of salsa. The code here works but is only available on github and from the `salsa-2022` crate.
>
> If you are looking for the older version of salsa, simply visit [this link](https://salsa-rs.netlify.app/salsa)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want some variant of this to indicate that it's not what is on crates.io

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #503

components/salsa-2022/src/debug.rs Show resolved Hide resolved
@@ -11,7 +11,9 @@ description = "Procedural macros for the salsa crate"
proc-macro = true

[dependencies]
eyre = "0.6.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use this? should probably look into that...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #504

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the lazy-input example, but not in the macro crate. I'll put up a PR.

src/debug.rs Show resolved Hide resolved
@nikomatsakis
Copy link
Member

I'm going to go ahead and merge this because it seems like conflict hell

@nikomatsakis nikomatsakis added this pull request to the merge queue Jun 19, 2024
Merged via the queue into salsa-rs:master with commit 38a44ee Jun 19, 2024
10 checks passed
@mbrobbel mbrobbel deleted the remove-old-salsa branch June 19, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the old Salsa, rename salsa-2022 crate to salsa
2 participants