fix(repo): fix relative includes cannot be used for sls requisites
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
|
LGTM, thanks @myii |
noelmcloughlin
approved these changes
Jun 4, 2020
* Semi-automated using myii/ssf-formula#218
myii
force-pushed
the
bug/fix-package-installation
branch
from
3aaad6b to
aba6e4c
Compare
|
Thanks for the review, @noelmcloughlin. |
|
🎉 This PR is included in version 0.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
myii
added a commit
to saltstack-formulas/packages-formula
that referenced
this pull request
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
packagesuite myii/ssf-formula#218slsrequisites #41Describe the changes you're proposing
fix(repo): fix relative includes cannot be used for
slsrequisitesslsrequisites #41slsrequisites #41 (comment)slsrequisites #41 (comment)fix(pkg): use correct package name per
osfamilygolangas default (majority of platforms)gofor SUSE and Arch Linuxfix(defaults): ensure
pathis set (for package-based installation)slsrequisites #41slsrequisites #41 (comment)ci(kitchen+travis+inspec): add
packagesuitePillar / config required to test the proposed changes
As provided.
Debug log showing how the proposed changes work
Documentation checklist
README(e.g.Available states).pillar.example.Testing checklist
state_top).Additional context