Skip to content

fix(repo): fix relative includes cannot be used for sls requisites #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2020

Conversation

myii
Copy link

@myii myii commented Jun 4, 2020

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

fix(repo): fix relative includes cannot be used for sls requisites

fix(pkg): use correct package name per osfamily

  • Use golang as default (majority of platforms)
  • Use go for SUSE and Arch Linux

fix(defaults): ensure path is set (for package-based installation)

ci(kitchen+travis+inspec): add package suite

Pillar / config required to test the proposed changes

As provided.

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested review from noelmcloughlin and a team as code owners June 4, 2020 22:45
@pull-assistant
Copy link

pull-assistant bot commented Jun 4, 2020

@noelmcloughlin
Copy link

LGTM, thanks @myii

@myii myii force-pushed the bug/fix-package-installation branch from 3aaad6b to aba6e4c Compare June 5, 2020 00:02
@myii
Copy link
Author

myii commented Jun 5, 2020

Thanks for the review, @noelmcloughlin.

@myii myii merged commit 5b1e9b7 into saltstack-formulas:master Jun 5, 2020
@myii myii deleted the bug/fix-package-installation branch June 5, 2020 00:49
@saltstack-formulas-travis

🎉 This PR is included in version 0.7.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

myii added a commit to saltstack-formulas/packages-formula that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Relative includes cannot be used for sls requisites
3 participants