staging.yml template: declare sign-macos-packages input - #70297
Merged
Merged
Conversation
Follow-up to the sign-macos-off-nightly change. That PR taught
build-packages.yml.jinja to emit
`sign-macos-packages: ${{ inputs.sign-macos-packages }}` in
non-nightly contexts, which means the RENDERED staging.yml now
references an `inputs.sign-macos-packages` field that was never
declared on staging.yml's own `on: workflow_call: inputs:` block.
actionlint on the Pre-Commit / Run Pre-Commit Against Salt job
catches this and rejects staging.yml with:
property "sign-macos-packages" is not defined in object type
{sign-deb-packages: bool; sign-rpm-packages: bool;
sign-windows-packages: bool; ...}
Local pre-commit runs did not surface this — likely because the
local actionlint binary is a slightly older version, or the hook
was skipped on the run. CI actionlint is stricter.
Fix: add sign-macos-packages: type=boolean, default=false to
templates/staging.yml.jinja next to the other sign-* inputs. The
regenerated staging.yml gets the new input declaration; the
existing `${{ inputs.sign-macos-packages }}` references at lines
518/541 now resolve correctly and actionlint stops complaining.
Regenerated .github/workflows/staging.yml via the Generate GitHub
Workflow Templates pre-commit hook.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the sign-macos-off-nightly change. That PR taught build-packages.yml.jinja to emit
sign-macos-packages: ${{ inputs.sign-macos-packages }}in non-nightly contexts, which means the RENDERED staging.yml now references aninputs.sign-macos-packagesfield that was never declared on staging.yml's ownon: workflow_call: inputs:block.actionlint on the Pre-Commit / Run Pre-Commit Against Salt job catches this and rejects staging.yml with:
Local pre-commit runs did not surface this — likely because the local actionlint binary is a slightly older version, or the hook was skipped on the run. CI actionlint is stricter.
Fix: add sign-macos-packages: type=boolean, default=false to templates/staging.yml.jinja next to the other sign-* inputs. The regenerated staging.yml gets the new input declaration; the existing
${{ inputs.sign-macos-packages }}references at lines 518/541 now resolve correctly and actionlint stops complaining.Regenerated .github/workflows/staging.yml via the Generate GitHub Workflow Templates pre-commit hook.