Skip to content

Fix infinite loop in zlib_mem_inflate() when uncomp_size=1 (CWE-835) #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lrycro wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix infinite loop in zlib_mem_inflate() when uncomp_size=1 (CWE-835) #2081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions cram/cram_io.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,8 +835,6 @@ char *zlib_mem_inflate(char *cdata, size_t csize, size_t *size) {
}

uint8_t *data = NULL, *new_data;
if (!*size)
*size = csize*2;
for(;;) {
new_data = realloc(data, *size);
if (!new_data) {
Expand All @@ -850,7 +848,7 @@ char *zlib_mem_inflate(char *cdata, size_t csize, size_t *size) {
// Auto grow output buffer size if needed and try again.
// Fortunately for all bar one call of this we know the size already.
if (ret == LIBDEFLATE_INSUFFICIENT_SPACE) {
(*size) *= 1.5;
*size = (*size + 1) + (*size >> 1);
continue;
}

Expand Down