Linting + Toast Issue

sandboxnu · Nov 23, 2024 · 8df9768 · 8df9768
1 parent 82482e8
commit 8df9768
Showing 1 changed file with 9 additions and 15 deletions.
diff --git a/apps/web/src/app/(pages)/(dashboard)/roles/page.tsx b/apps/web/src/app/(pages)/(dashboard)/roles/page.tsx
@@ -47,45 +47,39 @@ export default function Roles({
   useEffect(() => {
     setMounted(true);
   }, []);
+
   useEffect(() => {
-    if (!mounted) {
-      return;
-    }
-    if (!validationResult.success) {
+    if (mounted && !validationResult.success) {
       toast({
-        title: "Invalid search params",
+        title: "Invalid Search Parameters",
         description: validationResult.error.issues
           .map((issue) => issue.message)
           .join(", "),
         variant: "destructive",
       });
+      setMounted(false);
     }
-  }, [
-    toast,
-    mounted,
-    validationResult.success,
-    validationResult.error?.issues,
-  ]);
+  }, [toast, mounted, validationResult]);
 
   const reviews = api.review.list.useQuery({
     search: searchParams?.search,
     options: validationResult.success ? validationResult.data : {},
   });
 
   const [selectedReview, setSelectedReview] = useState<ReviewType | undefined>(
-    reviews.data ? reviews.data[0] : undefined,
+    reviews.isSuccess ? reviews.data[0] : undefined,
   );
 
   useEffect(() => {
-    if (reviews.data) {
+    if (reviews.isSuccess) {
       setSelectedReview(reviews.data[0]);
     }
-  }, [reviews.data]);
+  }, [reviews.isSuccess, reviews.data]);
 
   return (
     <>
       <SearchFilter search={searchParams?.search} {...validationResult.data} />
-      {reviews.data && (
+      {reviews.isSuccess && (
         <div className="mb-8 grid h-[70dvh] w-4/5 grid-cols-5 gap-4 lg:w-3/4">
           <div className="col-span-2 gap-3 overflow-scroll pr-4">
             {reviews.data.map((review, i) => {