Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max 5 Reviews Per User #110

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Max 5 Reviews Per User #110

merged 3 commits into from
Jan 26, 2025

Conversation

mattrwang
Copy link
Contributor

@mattrwang mattrwang commented Jan 22, 2025

Description

Runs a check on how many reviews a user has submitted before creating a new one, throws error if they hit the cap of 5.

Motivation and Context

Prevents users from submitting too many reviews, since each person can realistically complete no more than 5 experiences.

Closes #108

How has this been tested?

Created 5 reviews on a fresh account and saw them appear in drizzle studio. Attempted to create a 6th, did not show up in drizzle.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 7:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Jan 26, 2025 7:05pm
cooper-docs ⬜️ Skipped (Inspect) Jan 26, 2025 7:05pm

@mattrwang mattrwang requested a review from banushi-a January 22, 2025 18:03
@mattrwang mattrwang self-assigned this Jan 22, 2025
@vercel vercel bot temporarily deployed to Preview – cooper-docs January 22, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth January 22, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper January 22, 2025 18:44 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small changes but beautiful, prob can get merged during GM

@vercel vercel bot temporarily deployed to Preview – cooper-auth January 26, 2025 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs January 26, 2025 19:04 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

budget approved

@vercel vercel bot temporarily deployed to Preview – cooper January 26, 2025 19:05 Inactive
@mattrwang mattrwang merged commit 88a1f5a into main Jan 26, 2025
8 checks passed
@mattrwang mattrwang deleted the #108-max-5-reviews branch January 26, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Develop) Limit number of reviews
2 participants