Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky Login Requirement #115

Merged
merged 10 commits into from
Feb 2, 2025
Merged

Husky Login Requirement #115

merged 10 commits into from
Feb 2, 2025

Conversation

gpalmer27
Copy link
Contributor

@gpalmer27 gpalmer27 commented Jan 30, 2025

Description

Made it so that when a user logs in, they have to log in with their @husky.neu.edu email. If they try to log in with a different email, they are brought to a page that tells them to log in again with the correct email. The sign in/sign out button also redirects to the home page once it's clicked.

Motivation and Context

Closes #107

How has this been tested?

Trial and error with pressing the button over and over again :)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gpalmer27 gpalmer27 requested a review from banushi-a January 30, 2025 05:00
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 9:05pm
cooper-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 9:05pm
cooper-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 2, 2025 9:05pm

@vercel vercel bot temporarily deployed to Preview – cooper-docs January 30, 2025 05:08 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth January 30, 2025 05:08 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper January 30, 2025 05:09 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth January 30, 2025 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs January 30, 2025 05:10 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper January 30, 2025 05:11 Inactive
Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIREEEEE 🔥

Comment on lines +63 to +70
signIn({ user }) {
const email = user.email;

if (!email?.endsWith("@husky.neu.edu")) {
return "/redirection";
}
return true;
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLEAN 💯

@vercel vercel bot temporarily deployed to Preview – cooper January 30, 2025 23:48 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bada bing bada boom

Copy link
Contributor

@Yasoop Yasoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yippee

Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Develop) Require husky.neu.edu gmail when doing signup
4 participants