Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Migration CI #128

Merged
merged 12 commits into from
Feb 9, 2025
Merged

Add Migration CI #128

merged 12 commits into from
Feb 9, 2025

Conversation

RishikeshNK
Copy link
Collaborator

@RishikeshNK RishikeshNK commented Feb 8, 2025

Description

Add a GitHub Action workflow for running migrations on the production database (only for changes to main).

Motivation and Context

To reduce "points of failure" (forgot to run pnpm db:generate, forgot to run pnpm db:migrate on the production database, accidentally forgot to switch back to development database, etc).

How has this been tested?

Lemme think about this one 😛

Edit: Made it so that the CI also runs on all pull requests (temporarily) and spent half an hour trying to fix the Missing POSTGRES_URL only to realize that it is supposed to be a Repository Secret and not an Actions Secret (which still doesn't make sense to me but it works?).

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Feb 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2025 7:35pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Feb 9, 2025 7:35pm
cooper-docs ⬜️ Skipped (Inspect) Feb 9, 2025 7:35pm

@vercel vercel bot temporarily deployed to Preview – cooper-auth February 8, 2025 03:29 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs February 8, 2025 03:29 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper February 8, 2025 03:30 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs February 8, 2025 03:36 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth February 8, 2025 03:36 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yer

@@ -3,7 +3,8 @@
Cooper is a tool for Northeastern students to both submit reviews of their co-ops and filter through reviews of co-ops left by other students.

## The Cooper Docs
Read our docs [cooper-docs-sandboxney.verce.app](https://cooper-docs-sandboxneu.vercel.app/) !

Read our docs [cooper-docs-sandboxneu.vercel.app](https://cooper-docs-sandboxneu.vercel.app/) !
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

@RishikeshNK RishikeshNK merged commit a26a6d1 into main Feb 9, 2025
8 checks passed
@RishikeshNK RishikeshNK deleted the migration-ci branch February 9, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants