Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated review page #132

Merged
merged 15 commits into from
Feb 17, 2025
Merged

Updated review page #132

merged 15 commits into from
Feb 17, 2025

Conversation

gpalmer27
Copy link
Contributor

Description

Updated the review page to be more in line with the designs on Figma. Changed the layout on the jobs page to have separate roles on the side and then a corresponding role info card with a list of the reviews specific to that role listed below.

Motivation and Context

Makes the roles page match what's on the Figma and makes the role info card more helpful for seeing what a role is like.

Closes #119

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database migration
    • Ran pnpm db:generate and verified generated SQL migration files in packages/db/drizzle

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] I have moved the ticket to "In Review"
  • [ x] I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gpalmer27 gpalmer27 requested a review from banushi-a February 13, 2025 23:44
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:42pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Feb 17, 2025 9:42pm
cooper-docs ⬜️ Skipped (Inspect) Feb 17, 2025 9:42pm

Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gillian cracked frontend dev

small tailwind thing
@vercel vercel bot temporarily deployed to Preview – cooper-auth February 17, 2025 21:41 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs February 17, 2025 21:41 Inactive
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

letsss goooo

@gpalmer27 gpalmer27 merged commit 5a04fbd into main Feb 17, 2025
8 checks passed
@gpalmer27 gpalmer27 deleted the updated-review-page branch February 17, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Develop) Start Developing Roles Page
2 participants