Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NextAuth authentication #26

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Add NextAuth authentication #26

merged 9 commits into from
Feb 5, 2024

Conversation

RishikeshNK
Copy link
Collaborator

@RishikeshNK RishikeshNK commented Feb 3, 2024 •
edited
Loading

Description

  • Adds NextAuth authentication to the app.
    • Does not work on Vercel Previews yet. There is a workaround to that, however, that wouldn't be included in this PR since it is broken for some reason due to the NEXTAUTH_URL environment variable. In the future, remove NEXTAUTH_URL from Preview deployments and let env.js set NEXTAUTH_URL to VERCEL_URL as a fallback.
  • To review this Pull Request, set up the branch locally since Vercel preview is not working yet.

Note: Update your .env to have a GOOGLE_CLIENT_ID and GOOGLE_CLIENT_SECRET.

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2024 3:30pm

banushi-a
banushi-a approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working for me. I tried multiple accounts (locally) and each was able to log in (not just the one you added as a dev) and they correctly displayed the different account names. LGTM af

@RishikeshNK RishikeshNK merged commit 1373f90 into main Feb 5, 2024
4 checks passed
@RishikeshNK RishikeshNK deleted the add-nextauth branch February 5, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banushi-a banushi-a banushi-a approved these changes

@cinyecai cinyecai Awaiting requested review from cinyecai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishikeshNK @banushi-a