Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor Roles Page #53

Merged
merged 6 commits into from
Apr 11, 2024
Merged

feat: refactor Roles Page #53

merged 6 commits into from
Apr 11, 2024

Conversation

banushi-a
Copy link
Contributor

@banushi-a banushi-a commented Apr 1, 2024 •
edited
Loading

Changes:

  • Made necessary components client side (Navbar, roles page, etc.)
  • Screenshot 2024-04-09 at 10 03 44 PM
  • The above full right preview thing is temporary since there isn't a design yet but its super easy to change
  • Screenshot 2024-04-09 at 10 03 55 PM
  • This page is missing the functionality of when you search, that specific company comes up. Def needs to be a different pr since we'll have to look into fuzzy search and test out edge cases

TBH I never looked over this code again so tear it up LOL

@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 10:45pm

RishikeshNK

This comment was marked as resolved.

Sign in to view

cinyecai
cinyecai approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@cinyecai cinyecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ate !

@banushi-a banushi-a merged commit 58ceae1 into main Apr 11, 2024
4 checks passed
@banushi-a banushi-a deleted the modify-roles-page branch April 11, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cinyecai cinyecai cinyecai approved these changes

@RishikeshNK RishikeshNK RishikeshNK left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banushi-a @RishikeshNK @cinyecai