Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list endpoint accept an optional parameter for filtering #82

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

gpalmer27
Copy link
Contributor

Closes #71

Only add the task number to the above statement if you have finished all of the subtasks.

Description

Made list endpoint in review.ts accept optional parameter that defines work model and location to be met

Things to be reviewed

Screenshots (if applicable)

Checklist

  • Add task name to the PR title
  • Add ticket number to ("Closes #")
  • Update app/docs (if applicable)
  • Move task to "In Review" on the Cooper Project Board
  • Add atleast one person to review your PR
  • Ask for review on Slack

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:27pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Oct 4, 2024 3:27pm
cooper-docs ⬜️ Skipped (Inspect) Oct 4, 2024 3:27pm

Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIRE first PR!! We should be good to merge after that small refactor! :neckbeard:

@vercel vercel bot temporarily deployed to Preview – cooper-auth October 4, 2024 15:26 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs October 4, 2024 15:26 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper October 4, 2024 15:27 Inactive
Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gpalmer27 gpalmer27 merged commit ff00668 into main Oct 4, 2024
8 checks passed
@gpalmer27 gpalmer27 deleted the filtering branch October 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make list endpoint accept an optional parameter for filtering
3 participants