Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Search Params through Search Bar #84

Merged
merged 6 commits into from
Oct 6, 2024
Merged

Update Search Params through Search Bar #84

merged 6 commits into from
Oct 6, 2024

Conversation

suxls
Copy link
Contributor

@suxls suxls commented Oct 3, 2024

Closes #83

Only add the task number to the above statement if you have finished all of the subtasks.

Description

After user input something in search bar and press enter, url param updates to search: "...."
Works across all 3 pages.

Things to be reviewed

Rishi got it

Checklist

  • Add task name to the PR title
  • Add ticket number to ("Closes #")
  • Update app/docs (if applicable)
  • Move task to "In Review" on the Cooper Project Board
  • Add atleast one person to review your PR
  • Ask for review on Slack

@suxls suxls requested review from RishikeshNK and banushi-a October 3, 2024 23:50
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:56pm
cooper-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:56pm
cooper-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 8:56pm

Copy link
Contributor

@banushi-a banushi-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty good!

Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIYE 🚀

Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@joshw2048 joshw2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind aproval

@suxls suxls merged commit b9ba9ec into main Oct 6, 2024
8 checks passed
@suxls suxls deleted the fuzzy-search branch October 6, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update search param through the search bar
4 participants