-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
81: Fix funny looking scrolling #87
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry this took a day for me to review -- this was a massive PR 🌀
One more change (totally optional): but can you set a min content height / max height on the footer so that the footer doesn't take up the whole page when the data is being fetched? Should be a one line change somewhere.
Yer just made a change for that last thing, kinda simple like u said but it should work (?) ((god willing)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YUM
Description
Fix that one thing rishi pointe dout
Motivation and Context
Visual error. Also added some basic mobile responsiveness but designers may want to come up with some different solution for this anyways (I don't even think there are designs for what exists rn it was a showcase change LOL)
Closes #81
How has this been tested?
Looked at that shi with my eyes
Types of changes
Checklist: