Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81: Fix funny looking scrolling #87

Merged
merged 4 commits into from
Oct 21, 2024
Merged

81: Fix funny looking scrolling #87

merged 4 commits into from
Oct 21, 2024

Conversation

banushi-a
Copy link
Contributor

@banushi-a banushi-a commented Oct 20, 2024

Description

Fix that one thing rishi pointe dout

Motivation and Context

Visual error. Also added some basic mobile responsiveness but designers may want to come up with some different solution for this anyways (I don't even think there are designs for what exists rn it was a showcase change LOL)

Closes #81

How has this been tested?

Looked at that shi with my eyes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 1:56am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Oct 21, 2024 1:56am
cooper-docs ⬜️ Skipped (Inspect) Oct 21, 2024 1:56am

@vercel vercel bot temporarily deployed to Preview – cooper October 20, 2024 02:13 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs October 20, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth October 20, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper October 20, 2024 02:16 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs October 20, 2024 02:18 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth October 20, 2024 02:18 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper October 20, 2024 02:19 Inactive
@banushi-a banushi-a marked this pull request as ready for review October 20, 2024 02:22
@RishikeshNK RishikeshNK self-requested a review October 20, 2024 23:44
Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry this took a day for me to review -- this was a massive PR 🌀

One more change (totally optional): but can you set a min content height / max height on the footer so that the footer doesn't take up the whole page when the data is being fetched? Should be a one line change somewhere.

@vercel vercel bot temporarily deployed to Preview – cooper-auth October 21, 2024 01:55 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs October 21, 2024 01:55 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper October 21, 2024 01:56 Inactive
@banushi-a
Copy link
Contributor Author

LGTM! Sorry this took a day for me to review -- this was a massive PR 🌀

One more change (totally optional): but can you set a min content height / max height on the footer so that the footer doesn't take up the whole page when the data is being fetched? Should be a one line change somewhere.

Yer just made a change for that last thing, kinda simple like u said but it should work (?) ((god willing))

@banushi-a banushi-a requested a review from RishikeshNK October 21, 2024 02:03
Copy link
Collaborator

@RishikeshNK RishikeshNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YUM

@banushi-a banushi-a merged commit 33350dd into main Oct 21, 2024
8 checks passed
@banushi-a banushi-a deleted the 81-OverflowIntoFooter branch October 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix funny looking scrolling
2 participants