Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cooper Testing is CURSED #94

Merged
merged 10 commits into from
Nov 23, 2024
Merged

Cooper Testing is CURSED #94

merged 10 commits into from
Nov 23, 2024

Conversation

RishikeshNK
Copy link
Collaborator

@RishikeshNK RishikeshNK commented Nov 22, 2024

Description

@gpalmer27 's ticket 🥇

See #92

Includes tests for the API calls for filtering.

Motivation and Context

Closes #73

How has this been tested?

All the tests pass!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • I have added reviewers to this PR
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 15:35 Inactive
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cooper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cooper-auth ⬜️ Skipped (Inspect) Nov 22, 2024 4:16pm
cooper-docs ⬜️ Skipped (Inspect) Nov 22, 2024 4:16pm

@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 15:35 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 15:35 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 15:38 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 15:38 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 15:39 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 15:45 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 15:45 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:00 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:00 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 16:01 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:02 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:02 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:10 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:10 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 16:11 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:11 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:11 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 16:13 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-docs November 22, 2024 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper-auth November 22, 2024 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview – cooper November 22, 2024 16:16 Inactive
@RishikeshNK RishikeshNK changed the title [WIP] Cooper Testing is CURSED Cooper Testing is CURSED Nov 23, 2024
Copy link
Contributor

@gpalmer27 gpalmer27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gpalmer27 gpalmer27 merged commit e8a303d into main Nov 23, 2024
8 checks passed
@gpalmer27 gpalmer27 deleted the cooper-testing-is-cursed branch November 23, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write unit tests for filtering
2 participants