#95 empty state search #96
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
FIYE we needed this. I was thinking of doing it in the loading.tsx file (there's a loading skeleton ticket buried
somewhere on that board) but I think this is a better approach!
Edit: Found it! #51
| @@ -106,6 +108,8 @@ export default function Roles({ | |||
| </div> | |||
| </div> | |||
| )} | |||
| {reviews.isSuccess && reviews.data.length === 0 && <NoResults />} | |||
There was a problem hiding this comment.
Totally a nit but thoughts on doing this above the "main" return statement?
if (review.isPending) return <LoadingResult />
if (reviews.isSuccess && !reviews.data.length) return <NoResult />So then you can remove all of the checks from Line 85.
There was a problem hiding this comment.
ok so i lied, if we do this then the search bar isn't rendered and adding it to the above return statements duplicates like an extra 15 lines of code so I think it might be better to leave where they are?
There was a problem hiding this comment.
you're right i didn't realize that this was a page and that we have the SearchFilter component on it
| <Button | ||
| type="button" | ||
| variant="ghost" | ||
| onClick={clearFilters} | ||
| className="text-cooper-blue-600" | ||
| > | ||
| Clear Filters | ||
| </Button> |
There was a problem hiding this comment.
This button might not be centered. See this
Description
Adds super simple (ugly even) loading and no-results components.
Motivation and Context
So this was j bothering me, like we need to do actual designs but it was low effort so I figured why not.
Also changed the cooper logo to be a component bc i was tired of figuring out the ratio of height to width or whatever
Closes #95
How has this been tested?
You may be thinking, "Wow, Cooper has made so much progress this semester! But I wonder where there tests are?". You no longer need to fret! See, although I didn't write any tests yet, I think adding tests is a great ✨ winter break activity ✨. So you can rest assured that even though there aren't any yet, a soon-to-be PR will fill that gap and mend your worries ◡̈ .
Screenshots (if appropriate):
Types of changes
Checklist: